Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scx_lavd: fix two potential bugs #704

Merged
merged 2 commits into from
Sep 29, 2024
Merged

Conversation

multics69
Copy link
Contributor

This PR contains two potential bugs, one of which causes a stress test failure in CI.

  • scx_lavd: do not perform the victim selection for an invalid cpu
  • scx_lavd: fix incorrect neighbor_bit initialization

Changwoo Min added 2 commits September 29, 2024 02:22
When finding a victim candidate for preemption, a randomly chosen
candidate could be out of valid CPU range due to CPU offline, etc. In
this case, try another CPU randomly.

Signed-off-by: Changwoo Min <[email protected]>
Copy link
Contributor

@arighi arighi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for fixing this.

@multics69 multics69 merged commit 896ff0e into sched-ext:main Sep 29, 2024
18 of 19 checks passed
@multics69 multics69 deleted the lavd-ci-fix branch September 29, 2024 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants